config: generate default config from env #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我在考虑要不要让环境变量覆盖配置文件好？还是仅仅作为默认值？你觉得呢？ |
trim21
reviewed
Mar 29, 2023
|
readme？ |
|
感觉只用作初始化就好，基本这种特性的都是做容器部署的时候才用到，容器拉起来之后还会进去手动修改配置的话，操作的人应该很清楚自己在干啥（大概），那还是按他手动修改过的为准靠谱。 readme 回头补上（正好 github action 炸了 连 pr 的 lint 都还没过，回头等好了一块儿整 |
|
那等ci好了再合了（ |
|
ci挂了 |
|
好嘞 晚点修（iPhoneから送信30/3/2023 11:57、Trim21 ***@***.***>のメール:
@trim21 requested changes on this pull request.
修一下（
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
codysk
force-pushed
the
feaure/env-config
branch
4 times, most recently
from
c423cfa
to
40488f9
Compare
codysk
force-pushed
the
feaure/env-config
branch
from
40488f9
to
59a7f8d
Compare
|
ci 修了，但晚点我把 readme 也补上再合呗 |
codysk
force-pushed
the
feaure/env-config
branch
from
f3d114e
to
2357c4e
Compare
trim21
reviewed
Mar 30, 2023
|
|
||
| 环境变量 *暂不支持* 配置以下项目 | ||
| ``` | ||
| enable_global_include_keywords |
There was a problem hiding this comment.
就，反正开了这个还是要进去配置 global_include_keywords 之类的那些，环境变量就给他初始化个开关没啥用的样子。
trim21
reviewed
Mar 30, 2023
Co-authored-by: Trim21 <trim21.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持一些环境变量用于初始化配置 #430