Feature/mikan url config #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codysk
force-pushed
the
feature/mikan-url-config
branch
from
b038361
to
77041ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 42.19% 42.25% +0.05%
==========================================
Files 32 32
Lines 2237 2239 +2
==========================================
+ Hits 944 946 +2
Misses 1293 1293
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
trim21
reviewed
Apr 23, 2023
bgmi/website/mikan.py
Outdated
| @@ -14,13 +15,13 @@ | |||
| from bgmi.website.base import BaseWebsite | |||
| from bgmi.website.model import Episode, SubtitleGroup, WebsiteBangumi | |||
|
|
|||
| server_root = "https://mikanani.me/" | |||
| server_root = f"{cfg.mikan_url}/" | |||
trim21
reviewed
Apr 23, 2023
| @@ -299,7 +306,7 @@ def search_by_tag(self, tag: str, subtitle: Optional[str] = None, count: Optiona | |||
| title_el = item.find("title") | |||
| title = title_el.text if title_el is not None else None | |||
|
|
|||
| xmlns = "{https://mikanani.me/0.1/}" | |||
| xmlns = "{" + server_root + "0.1/}" | |||
There was a problem hiding this comment.
我实际找了个镜像站测的，确实会改的样子。
如果是nginx搭的那种镜像站，应该所有看起来像本站url的东西都会被改掉的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
从前两天开始大陆地区访问不到 mikanani.me 了，这个 pr 给 mikan 增加了镜像站配置的支持。