fix(mikan): ignore empty subtitle_group list #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果用mikan源的话，主页上面的没有字幕组的名字，在
bgmi cal --force-update的时候就会覆盖掉之前获取到的字幕组，导致再 list 就没了但是好像还需要区分是没有在WebsiteBangumi里面填subtitle还是原本有subtitle但是又被清空了，所以就改成了可以None用来区分，虽然好像这个情况不存在放弃了，直接在更新的时候检查一下是不是empty了