Validations are being ignored

[mrmte]

Describe the bug
I have set validations such as Google Chrome (/Applications/Google Chrome.app), Microsoft Office (/Applications/Microsoft Outlook.app)
Swifit Dialog (setup my mac) shows failed, even though they have not

To Reproduce

• Please describe the steps to reproduce the bug.
• setup the config for validations, export the script.
• run the script via jamf to setup your mac

Expected behavior

• Installed apps with the validation passing should not show failed as they have not

Code/log output

• Please add full output. Either upload the log, or paste the output in a code block (triple backticks at the start and end of the code block, please!).
  \
  2023-12-07 10:34:19 -

#

FAILURE DIALOG

#

2023-12-07 10:34:19 - Jamf Pro Policy Name Failures:
2023-12-07 10:34:19 - • [DEPNotify] Install Zoom
• [DEPNotify] Microsoft Office
• Google Chrome
• Zscaler
• [DEPNotify] CrowdStrike

2023-12-07 10:34:19 - FAILURE DIALOG: message: A failure has been detected, Tim.

Please complete the following steps:

1. Reboot and login to your MacBook Pro
2. Login to Self Service
3. Re-run any failed policy listed below

The following failed:
• [DEPNotify] Install Zoom
• [DEPNotify] Microsoft Office
• Google Chrome
• Zscaler
• [DEPNotify] CrowdStrike

If you need assistance, please contact the

• Telephone:
• Email: support@servicenow.com
• Knowledge Base Article: id=kb_article_view&sysparm_article=#Failures)

2023-12-07 10:34:19 - FAILURE DIALOG: icon: SF=xmark.circle.fill,weight=bold,colour1=#BB1717,colour2=#F31F1F
2023-12-07 10:34:19 - FAILURE DIALOG: button1text: Restart
2023-12-07 10:34:34 - FAILURE DIALOG: quit:
2023-12-07 10:34:34 - QUIT SCRIPT: Exiting …
2023-12-07 10:34:34 - QUIT SCRIPT: De-caffeinate …
2023-12-07 10:34:34 - The 'caffeinate' process isn't running.
2023-12-07 10:34:34 - QUIT SCRIPT: Removing /var/tmp/dialogCommandFileWelcome.vPd …
2023-12-07 10:34:34 - QUIT SCRIPT: Removing /var/tmp/dialogCommandFileSetupYourMac.gAB …
2023-12-07 10:34:34 - QUIT SCRIPT: Removing /var/tmp/dialogCommandFileFailure.j7X …
2023-12-07 10:34:34 - QUIT SCRIPT: Removing default dialog file …
2023-12-07 10:34:34 - QUIT SCRIPT: Executing Completion Action Option: 'Restart Attended' …
2023-12-07 10:34:34 - COMPLETION ACTION: Restart, requiring user-interaction
2023-12-07 10:34:34 - The 'Self Service' process isn't running.
2023-12-07 10:34:34 - COMPLETION ACTION: Removing /var/tmp/green-abstract-geometric-wallpaper_52683-29623.jpg …
2023-12-07 10:34:34 - COMPLETION ACTION: Removing /var/tmp/overlayicon.icns …
\\

Screenshots

• If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

• OS version (i.e., macOS 14.0)
  14.1.1

• SYM-Helper version (i.e., 0.7.7 (20230919-91A)) - please upgrade to the latest version before submitting a bug report.
  0.8.3 (20231028-6D2)

Additional context

• Add any other context about the problem here.

[dan-snelson]

@mrmte:

Currently, SYM is looking for a filepath not a directory.

• Included Working Examples
  • Outlook
  • Chrome

See also: Setup Your Mac with SYM-Helper.app.

[dan-snelson]

Please also upgrade to SYM-Helper v1.0.0.

ICYMI: About the security content of macOS Sonoma 14.1.2.

[mrmte]

@mrmte:

Currently, SYM is looking for a filepath not a directory.

• Included Working Examples

  • Outlook
  • Chrome

See also: Setup Your Mac with SYM-Helper.app.

if you change line 1824 to a -e rather than -f then for validations we can just us an app, directory or file. Its worth changing as this would mean i could use "/Applications/Google Chrome.app"

[dan-snelson]

Thanks for the inspiration, @mrmte!