Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Admin Strings #18

Closed
SomosAMambo opened this issue Mar 24, 2017 · 8 comments
Closed

Localize Admin Strings #18

SomosAMambo opened this issue Mar 24, 2017 · 8 comments
Assignees
Labels

Comments

@SomosAMambo
Copy link

SomosAMambo commented Mar 24, 2017

It would be great if all strings hardcoded into admin may be translated via lang* files.
Some of the strings are hardcoded in the index.js file (filters in listings, datepicker, etc).
I'm willing to pull my Brazilian Portuguese pack.

@weotch
Copy link
Member

weotch commented Mar 24, 2017

What do you mean by lan files? I'm not familiar with that term.

@SomosAMambo
Copy link
Author

Sorry. Typo for "lang". Localization files natively supported by Laravel. resources\lang

@weotch weotch added the feature label Mar 28, 2017
@SomosAMambo
Copy link
Author

Hello guys! This is very important for wider adoption. Our clients loved the CMS, but their teams can't read english.
There's also javascript strings, date fields, ...

I think this is too core related for a PR. But... we are committed to pull ours translations.

Is there plans to release this soon?

@weotch
Copy link
Member

weotch commented Apr 12, 2017

Next week I think we could tackle the changes that need making in the core. Specifically:

  • Use lang files for strings rendered in PHP
  • Passthrough lang configs to JS for use in strings rendered by JS

We'll implement the more obvious cases that pop up using these new systems and then you can PR any additional cases you find with your Portuguese pack, cool?

@SomosAMambo
Copy link
Author

Damn yeah!

@brokenhd
Copy link
Member

@SomosAMambo on dev-master we started localization for Portuguese (note that I used google translate so it's probably not 100% accurate). Also stubbed out the javascript string localization as well. Take a look at how we approached it and you can PR the rest.

@SomosAMambo
Copy link
Author

Fantastic @brokenhd! Testing already. First thing I've noticed is that you did a great job translating to Brazilian Portuguese (aside from minor details) but the ISO language code for our language is pt-BR (Laravel treats it as pt_BR), "pt" is used for portuguese from Portugal. I'll tackle into the code now and PR.

You guys are great! Thank you!

@SomosAMambo
Copy link
Author

SomosAMambo commented Apr 21, 2017

Maybe... what do you guys think about publishing the localization files to resources\lang dir?

It'll allow devs to override strings on a project basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants