Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lumen 6.0] Unsupported Laravel Version #72

Closed
Smankusors opened this issue Sep 14, 2019 · 5 comments
Closed

[Lumen 6.0] Unsupported Laravel Version #72

Smankusors opened this issue Sep 14, 2019 · 5 comments

Comments

@Smankusors
Copy link

Actually, there's something breaking when checking the version. When you call $app->version(), Lumen 6.0 will actually returns "Lumen (6.0.2) (Laravel Components ^6.0)" (note that there's caret after "Laravel Components").

Interestingly, when this called on Laravel 6.0, that function would return "6.0.3" instead. Also in Lumen 6.0, it didn't have VERSION constant. I feels like there's some inconsistency with Laravel code here.

What do you think? Should this be issue on your package or this should be Laravel's problem?

Thanks,

@kylekatarnls
Copy link
Collaborator

If Lumen version is no longer synchronized with Laravel components version, we'll have to check if there is a proper way to get the exact version of Laravel components, else we could: ask Lumen team to create it and meanwhile guess it from ^6.0 in the string.

@kylekatarnls
Copy link
Collaborator

At a first sight, the version string in Lumen is hard-coded so probably has not the laravel components version alone anywhere: https://github.com/laravel/lumen-framework/blob/9b3182e48142e3e61648ed3733d18c0bfbee2f0d/src/Application.php#L143

@kylekatarnls
Copy link
Collaborator

For 4 to 6 version support, simply ignoring ^ and other possible symbols will be fine, I jut hope nothing incompatible would come up before version 7.

@kylekatarnls
Copy link
Collaborator

Please try to update to 1.9.1

@Smankusors
Copy link
Author

yeap that fixed this. Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants