Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Disable screen lock #189

Closed
JOJ0 opened this issue Apr 25, 2023 · 13 comments
Closed

[Feature request] Disable screen lock #189

JOJ0 opened this issue Apr 25, 2023 · 13 comments
Labels
TestInBeta This feature can be tested in Beta

Comments

@JOJ0
Copy link

JOJ0 commented Apr 25, 2023

When downloading larger amounts of files it would help if amperfy would prevent screen locking since I think downloading in the background doesnt seem to work / stops at some point. At least on ios it's what I experience with a lot of apps. A config option would be nice to let users choose whether amperfy prevents locking or not.

Do you think it's doable? I recently saw this feature in another subsonic client on ios. Not sure which language/framework it is written in though...

@Jaffex
Copy link

Jaffex commented May 10, 2023

I second this request - I use my phone for playing music in my car (i don't have carplay) and it'd be great if amperfy would prevent locking the screen so I can always see album art and media controls without tapping the screen.

It may make sense to create a setting like this:

Prevent Screen Lock

  • Never
  • When connected to charger
  • Always

@JOJ0
Copy link
Author

JOJ0 commented May 10, 2023

@Jaffex thanks for seconding! My main usecase is that I'm never able to finish my downloads because screen locks before that. How are you managing this issue when caching stuff for a car ride?

@Jaffex
Copy link

Jaffex commented May 10, 2023

I didn't cache the entire library yet, so when a song plays that is not cached yet, I stream it via mobile data.

@JOJ0
Copy link
Author

JOJ0 commented May 11, 2023

Ok I understand. I use it differently. I only stream at home and I dont have my subsonic compatible server facing the internet. Only offline mode when on the go / in the car. Thus making huge amounts of playlists available offline is a key feature for a subsonic client suitable for my needs.

You said "entire library", that wouldnt even fit on my 64GB phone, haha ;-)

@JOJ0
Copy link
Author

JOJ0 commented May 24, 2023

@BLeeEZ what's your thoughts on a feature like this? Since it's a FOSS project I wouldnt consider anything really soon now. Do you think it's useful and what are your next goals in the project?

@BLeeEZ
Copy link
Owner

BLeeEZ commented May 24, 2023

Hi all,
downloads are handled in iOS download session. Started downloads should finish, even in background.
Nevertheless screen lock prevention looks like a great feature.
The problem is that I currently have no free time realise this feature.

@JOJ0
Copy link
Author

JOJ0 commented May 25, 2023

Hi @BLeeEZ, thanks for the response. Yeah I get that, maintaining and at the same time coding new features in a FOSS project eats up a lot of time and often projects even are "one person show". Unfortunately no iOS/Swift programmer, just a FOSS Python-dev and currently also taking a "summer break" from the projects I'm involved with :-)

I'm not sure what iOS download session is, I guess it is a Swift feature?

From what I can say from my usages of iPhones and not only this app but other apps (even the Spotify app): I'm really not sure if it really "stays up" in background forever. I have the feeling that at some point the app / the phone gets to sleep and massive download sessions always end up dead. The only way, very often, is to keep the screen running, thus the app in the foreground. Sorry for not being technical here, I will try to tail my Navidrome server logs and make some definitive statements about if I see that transcoding/downloading stops if my desplay turns black.

One more thing to report which fits into this feature request is that I can definitely say, because I have just watched my navidrome containers log and can repro it definitely is:

"Download all artwork" stops like 1-2 minutes after my screen locks - if I unlock the phone again I suddenly see that downloads in my containers log are continuing. It certainly might be that you coded this feature differently and it does not use "iOS download session" and thus this is expected.

@BLeeEZ
Copy link
Owner

BLeeEZ commented Dec 10, 2023

This feature is implement via 19a06ec:
Simulator Screen Shot - iPhone 14 Pro Max - 2023-12-10 at 22 06 44

@JOJ0
Copy link
Author

JOJ0 commented Dec 11, 2023

Awesome news @BLeeEZ , let me no if you publish a testflight release. I'll test it and report back my experience. HTH

@JOJ0
Copy link
Author

JOJ0 commented Jan 21, 2024

Hi @BLeeEZ did this make it into 1.1.4? Thanks!

@BLeeEZ
Copy link
Owner

BLeeEZ commented Jan 21, 2024

Hi, this feature will be available in v1.1.5.

@BLeeEZ
Copy link
Owner

BLeeEZ commented Jan 25, 2024

This feature can be tested in v1.1.5 (2). It is now available as Beta via TestFlight: #25

@BLeeEZ BLeeEZ added the TestInBeta This feature can be tested in Beta label Jan 25, 2024
@BLeeEZ BLeeEZ closed this as completed Feb 25, 2024
@JOJ0
Copy link
Author

JOJ0 commented Feb 25, 2024

Thanks so much! Sorry for not reporting back! Works flawlessly on my iphone13 mini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestInBeta This feature can be tested in Beta
Projects
None yet
Development

No branches or pull requests

3 participants