Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify documents and packets tables to include short description #84

Closed
carlbennett opened this issue Mar 12, 2018 · 7 comments
Closed

Comments

@carlbennett
Copy link
Member

carlbennett commented Mar 12, 2018

Short description could be used on the document and packet index pages instead of deriving them from the document/packet's first sentence.

@nmbook
Copy link
Member

nmbook commented Mar 12, 2018

This is the same for documents too. I thought it was intended?

@carlbennett
Copy link
Member Author

We should include documents while implementing this feature.

@carlbennett
Copy link
Member Author

We could also make it used the derived value if there's no short description.

@carlbennett
Copy link
Member Author

Another flag could be added to the options bitmask that allows specifying whether to allow an empty short description, or to deny an empty short description and instead derive the value.

@carlbennett
Copy link
Member Author

Thoughts?

@carlbennett carlbennett changed the title Modify packets table to include short description Modify documents and packets tables to include short description Mar 12, 2018
@nmbook
Copy link
Member

nmbook commented Mar 12, 2018

Would this options bitmask be per packet? If you mean something per packet, wouldn't it make more sense to just have the field be nullable? If present and non-empty, use it. Otherwise, use current generated value.

@carlbennett carlbennett added this to Backlog in BNETDocs: Phoenix Mar 12, 2018
@carlbennett carlbennett moved this from Backlog to In Progress in BNETDocs: Phoenix Jul 23, 2021
@carlbennett carlbennett self-assigned this Jul 23, 2021
@carlbennett
Copy link
Member Author

This has been implemented as of 232be88.

@carlbennett carlbennett moved this from In Progress to Done in BNETDocs: Phoenix Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants