Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe optimizations #7

Open
Kixunil opened this issue Jul 13, 2022 · 1 comment
Open

unsafe optimizations #7

Kixunil opened this issue Jul 13, 2022 · 1 comment

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 13, 2022

I wonder if it'd be useful to have a feature unsafe-optimizations that turns on unsafe code with the only intention to optimize. Currently the candidate is using [MaybeUninit<u8>; 65] inside SerializedPublicKey. Relies on correct impl in secp256k1 ofc but that one already calls memset on the whole array 🙈
@dr-orlovsky
Copy link
Member

I am not against unsafe when it is behind the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr-orlovsky @Kixunil