Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML mode GUI issue : handling complex GML geometry ? #30

Closed
sgrellet opened this issue Aug 10, 2017 · 7 comments
Closed

XML mode GUI issue : handling complex GML geometry ? #30

sgrellet opened this issue Aug 10, 2017 · 7 comments
Assignees

Comments

@sgrellet
Copy link
Member

When loading the following URI (http://ressource.brgm-rec.fr/data/EntiteHydroGeol/121AT30) the feature is correctly identified but it is not possible to retrieve information from it with the 'identify' function.

As this resource is related to another issue #29, I removed manually the un-necessary FeatureCollection / Members.
See file attached (remove the trailing .txt for import):
EntiteHydroGeol.121AT30.xml.txt
But the problem remains.

Is it linked to the complex geometry that may cause issue to store it temporarily in SpatialLite ?

@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

This seems to be related to a particular geometry invalidity case that QGIS has problems to handle correctly ...

@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

When exporting the geometry in PostGIS:

select st_isvalid(geom) from ta;
NOTICE:  Hole lies outside shell at or near point 1.6533408259337787 50.621265734925082

@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

Works correctly in GMLAS mode.
The XML mode is using the OGR Python API to extract the geometry from XML though

@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

@sgrellet using the equivalent of ST_MakeValid() in QGIS seems to solve the problem.
Do you think we need a checkbox "[ ] Make geometries valid" ?

@sgrellet
Copy link
Member Author

@mhugo : I received so many comments regarding the client saying : "that's cool but not accessible to the layman" that I would force it implicitly. Is there a way to log somewhere on the client side that initially the geom was invalid (I am afraid this will trigger another pass on the geometry no?)

@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

@sgrellet ok :) Actually, I am digging deeper, and the geometry should not be invalid here. The code is creating a polygon, where we should have a multipolygon ... investigations in progress.

@mhugo mhugo closed this as completed in de5f916 Sep 22, 2017
@mhugo
Copy link
Collaborator

mhugo commented Sep 22, 2017

It was just that multipolygons was not handled. Fixed now

@sgrellet sgrellet added this to Done in GMLAS toolbox 1.2.0 Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants