adjusted TimeElapsed for interruptions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,7 +147,7 @@ def __init__(self, sec): | |||
| self.start = time.time() | |||
|
|
|||
| def __call__(self, info): | |||
| return time.time() - self.start > self.sec | |||
| return getattr(info, 'time', time.time()) - self.start > self.sec | |||
There was a problem hiding this comment.
But if info is a dictionary, it won't ever have that attribute, it should be info.get('time', time.time()) to check for a key instead.
There was a problem hiding this comment.
Correct. My bad. Thanks.
previously, TimeElapsed would simply calculate time from its instantiation, which is problematic if the experiment is interrupted thereafter. Now it can read out the info dict which can hold a more meaningful runtime value.
msoelch
force-pushed
the
feature-timemgmt
branch
from
9b125e2
to
6b3124a
Compare
|
Should be good now. |
bayerj
added a commit
that referenced
this pull request
Sep 28, 2015
adjusted TimeElapsed for interruptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, TimeElapsed would simply calculate time from its
instantiation, which is problematic if the experiment is interrupted thereafter. Now it can read out the info dict which can hold a more
meaningful runtime value.