Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New world edit mechanism not consistently blocking the calculation blocks from being placed #105

Open
george112n opened this issue Jun 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@george112n
Copy link
Member

george112n commented Jun 17, 2024

The world edit command that is run through the console and is meant to be caught sometimes doesn't get detected and blocked, so the outlines of Stage 2 Step 2 are placed on the actual world, blocking the place tasks in Step 1.

These then remain and block all future lessons for this location.

@george112n george112n added the bug Something isn't working label Jun 17, 2024
@george112n george112n self-assigned this Jun 17, 2024
@george112n
Copy link
Member Author

This issue did not arise in testing but seems to happen reasonably frequently so I can probably test it enough times and eventually find a time that it does it wrong.

That is to say, the correct/incorrect behaviour is not consistent.

@george112n
Copy link
Member Author

george112n commented Jun 24, 2024

This is purely due to FAWE being on the production server but regular WorldEdit being on the test server. The event mechanism doesn't work with FAWE, presumably unless there is tight time control (increasing the time between each initialisation of a command to be sure that the event is only catching the command it is created for), but this is still not safe. It is safer to have WorldEdit and be sure that things are done in sync.

Fixing this therefore doesn't seem necessary, since worldedit is strongly required.

@george112n george112n closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
@george112n
Copy link
Member Author

WorldEdit does not have all the features that FAWE has, and I believe I have identified the issue. When resuming tutorials the registration of groups does not include the time gaps and therefore the events for tracking world edit changes overlap.

Furthermore I believe that adding a longer between registration would be fine. I shall however make this configurable for easier testing. It may be that the resume lesson issue was the only problem causing this, we will see in testing.

This will be added to version 8.1.1 to give 8.1.2

@george112n george112n reopened this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant