Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic /help functionality #23

Merged
merged 5 commits into from Sep 29, 2022
Merged

Basic /help functionality #23

merged 5 commits into from Sep 29, 2022

Conversation

AverageHelper
Copy link
Contributor

@AverageHelper AverageHelper commented Sep 29, 2022

At its very basic, /help lists the commands available to the user. This is at least a start.

Screen Shot 2022-09-28 at 23 23 19

This command will automatically include new commands as they're added in src/commands/index.ts.

Closes #8

@AverageHelper AverageHelper requested a review from a team September 29, 2022 04:55
@AverageHelper AverageHelper self-assigned this Sep 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 29, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
92.02% (+0.35% 🔼)
242/263
🟢 Branches
81.05% (+0.41% 🔼)
77/95
🟢 Functions
97.3% (+0.15% 🔼)
36/37
🟢 Lines
91.76% (+0.34% 🔼)
234/255

Test suite run success

66 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 5c38aec

Copy link
Contributor

@gmacgre gmacgre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those two small fixes, LGTM

src/commands/help.ts Show resolved Hide resolved
src/commands/help.ts Show resolved Hide resolved
Copy link
Contributor

@gmacgre gmacgre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we have everything we need now for this command.

@gmacgre
Copy link
Contributor

gmacgre commented Sep 29, 2022

Note- We may want to wait for one more person to approve this before merging.

@AverageHelper AverageHelper requested a review from a team September 29, 2022 06:44
@AverageHelper AverageHelper merged commit efc1151 into main Sep 29, 2022
@AverageHelper AverageHelper deleted the avg/help branch September 29, 2022 07:05
@JstnMcBrd
Copy link
Contributor

Oh I forgot to mention, probably should keep the changelog up to date.

@AverageHelper
Copy link
Contributor Author

Fair point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slash Command - basic Help
3 participants