Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings #551

Closed
gunnarhj opened this issue Jan 15, 2021 · 1 comment
Closed

Build warnings #551

gunnarhj opened this issue Jan 15, 2021 · 1 comment
Assignees

Comments

@gunnarhj
Copy link

gunnarhj commented Jan 15, 2021

Hi!

In connection with a QA review in Ubuntu a couple of opencc build warnings were pointed out:

/<<BUILDDIR>>/opencc-1.1.1+git20200624+ds2/src/PhraseExtract.cpp:104:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<std::pair<opencc::UTF8StringSliceBase<unsigned char>, opencc::PhraseExtract::Signals> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  104 | for (int i = 0; i < items.size(); i++) {
      | ~~^~~~~~~~~~~~~~

/usr/bin/ld: CMakeFiles/opencc.dir/CommandLine.cpp.o: in function `Convert(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)':
./obj-x86_64-linux-gnu/src/tools/./src/tools/CommandLine.cpp:89: warning: the use of `tmpnam' is dangerous, better use `mkstemp'

It would be great if somebody could address those to improve the robustness of the opencc project.

@BYVoid
Copy link
Owner

BYVoid commented Feb 25, 2021

cf4b5df

@BYVoid BYVoid closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants