Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IOS Simulator arm64 binaries to npm packages #451

Open
SergioRZMasson opened this issue Aug 23, 2022 · 7 comments
Open

Added IOS Simulator arm64 binaries to npm packages #451

SergioRZMasson opened this issue Aug 23, 2022 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@SergioRZMasson
Copy link
Contributor

Context

We currently ship @babylonjs/react-native-iosandroid packages with only x86_64 binaries for the IOS Simulator platform. This makes users that consume the package on arm64 MacBook's to be forced to manually modify their Podfile and .xcodeproj to force project to be compiled only for x86_64 Simulator and run under Rossetta. If arm64 binaries were provided I believe everything would work out of the box.

Improvement

Include arm64 IOS Simulator binaries in packages

  • @babylonjs/react-native-iosandroid-64
  • @babylonjs/react-native-iosandroid-65
  • @babylonjs/react-native-iosandroid-69
@SergioRZMasson SergioRZMasson added the enhancement New feature or request label Aug 23, 2022
@ryantrem
Copy link
Member

If I recall I think there is an issue with the way we currently create the libs... we use lipo to merge the x86 and arm libs into a single lib, and the correct architecture is chosen when linking later. However, I believe lipo can't merge two different arm libs (device and simulator). I think we have to switch to an xcframework or something.

@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc added this to the 6.0 milestone Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@bghgary bghgary modified the milestones: 6.0, Future Dec 1, 2022
@lucasff
Copy link

lucasff commented Feb 18, 2023

@SergioRZMasson would be possible to document here the approach to force the build to work?

@stetbern
Copy link

Xcode will stop supporting Rosetta in 14.3, I think this issue will be important for many developers soon: https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes

@SergioRZMasson
Copy link
Contributor Author

@bghgary @CedricGuillemet for visibility.

@bghgary
Copy link
Contributor

bghgary commented Jun 9, 2023

@bghgary bghgary modified the milestones: Future, 7.0 Jun 9, 2023
@bghgary bghgary modified the milestones: 7.0, Future Oct 12, 2023
@ChaimMark
Copy link

Do you happen to have any updates on the adding arm binaries?

@CedricGuillemet
Copy link
Contributor

Do you happen to have any updates on the adding arm binaries?

Sorry, no update yet. But it's still on our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants