Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 profiling #77

Open
CedricGuillemet opened this issue Feb 13, 2024 · 1 comment
Open

V8 profiling #77

CedricGuillemet opened this issue Feb 13, 2024 · 1 comment
Milestone

Comments

@CedricGuillemet
Copy link
Contributor

CedricGuillemet commented Feb 13, 2024

Following update on node-api, profile V8 to check for performance regression, in particular the use of private_key.
Spheres test in UnitTests can be a start.

I think more CPP tests that test a specific part of JSEngine<->CPP communication layer is the way to go.
From what I've seen so far, still with UnitTests, is most time taken by bgfx.

@bghgary
Copy link
Contributor

bghgary commented Feb 21, 2024

I pushed a fix in the PR to fix the regression. I can't remember how I determined this was the slow down, so it would be great to figure out how to figure this out. 😄 It would also be good if we can push this fix upstream to node, so that everyone would benefit.

@thomlucc thomlucc modified the milestones: Future, 8.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants