You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following update on node-api, profile V8 to check for performance regression, in particular the use of private_key.
Spheres test in UnitTests can be a start.
I think more CPP tests that test a specific part of JSEngine<->CPP communication layer is the way to go.
From what I've seen so far, still with UnitTests, is most time taken by bgfx.
The text was updated successfully, but these errors were encountered:
I pushed a fix in the PR to fix the regression. I can't remember how I determined this was the slow down, so it would be great to figure out how to figure this out. 😄 It would also be good if we can push this fix upstream to node, so that everyone would benefit.
Following update on node-api, profile V8 to check for performance regression, in particular the use of private_key.
Spheres test in UnitTests can be a start.
I think more CPP tests that test a specific part of JSEngine<->CPP communication layer is the way to go.
From what I've seen so far, still with UnitTests, is most time taken by bgfx.
The text was updated successfully, but these errors were encountered: