-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suddenly spector UX is super unresponsive on Chrome Linux #133
Comments
Ohhhhh we updated recently Ace.js, the editor library we are using. I hope it is not related. Do you happen to have a repro site ? Else I ll revert to the previous editor version. |
Try any of these: https://threejs.org/examples/#webgl_materials_variations_standard |
Ok, it is slow as well on windows :-( let me check if it is the editor update but as it feels slowish in general, I wonder if it is not the entire rendering we are using I ll keep you posted ASAP. |
Can you please try on https://playground.babylonjs.com/#G3GZA1#49 and let me know ? Would like to be sure it is the code beautifier in use when no edit is possible. |
Yup, looks more and more like it could be the latest version of PRISM. @elalish if you confirm you do not have issues with shaders of https://playground.babylonjs.com/#G3GZA1#49 I ll use ace.js in readonly mode instead and re deploy ASAP. |
I'm guessing you've already redeployed because everything is working great now. Thanks! |
I did not :-) so something is strange with latest. I close it but please. @elalish let me know if that happens again and we ll make sure to track it down. |
@sebavan Strange, it now seems sort of in-between. Perhaps it did crash and restart and that got it working again? It seems to be getting steadily slower. Maybe some kind of memory leak? I notice it especially when trying to highlight shader text in a long shader. |
ohhhhhh interesting and is it slow on https://playground.babylonjs.com/#G3GZA1#49 as well ? Trying to understand if the leak is in the beautifier ? |
@sebavan Interesting, your link works fine, even when I spector it. I've also spectored my link above, and mine has terrible performance while yours is good. The primary difference seems to be that the shaders in my link are much longer. |
Ok so it looks like the newer version of prism we use to be compliant with firefox compliance policies is the culprit :-( I will try to create an ace only based version over the week end to solve it. Thanks a lot for your report. |
Should be "fixed" on latest (currently in review in the chrome extension dashboard) Fixed is quoted cause I replaced the shader beautifier which was creating the slow behavior by the one we use for editable shaders. All available in v0.9.13 |
Everything is working for capture, but when I click to open a shader and try to scroll through it, it will take many seconds to respond to my scroll, or pretty much any other input. At one point it got so unresponsive that I think the whole extension crashed, as the icon no longer responds to clicks.
The text was updated successfully, but these errors were encountered: