DXT internal format size missing

[ivanpopelyshev]

Thanks from PixiJS team for a wonderful tool!

I'm debugging an app with big number of .dds resources, and I found that baseRecorder doesnt contain the size for most of compressed texture formats.

Spector.js/src/backend/recorders/baseRecorder.ts

Line 23 in 1313c95

this.byteSizePerInternalFormat = {

In my case its COMPRESSED_RGBA_S3TC_DXT5_EXT.

The size is defaulting to 4:

Spector.js/src/backend/recorders/baseRecorder.ts

Line 200 in 1313c95

return bytesPerElements || 4;

[Busyrev]

I think that it should be better to show warning to user, not just shallow unknown texture format here

Spector.js/src/backend/recorders/baseRecorder.ts

Line 200 in 1313c95

return bytesPerElements || 4;

[ivanpopelyshev]

Btw, it also doesnt take into account type of texture in case of WebGL1: FLOAT textures there have internalFormat RGBA and not RGBA32F.

[sebavan]

Yup, totally agree with that, unfortunately I am totally short on time these days, do you want to create a PR for it ?

[ivanpopelyshev]

I'm on it

[ivanpopelyshev]

Btw, its not a bug. According to what I saw in the source code - its more of a feature-request.