Ensure case is normalized on Windows when comparing paths from XML coverage report #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verage report This fixes a subtle problem on Windows, which is case-preserving but case-insensitive. Depending from where the user executed the coverage command to produce the XML file, the `<sources>` tag might contain a different case in the drive letter: `w:\foo\bar` vs `W:\foo\bar` (note the case of the first letter). On Windows both paths should be considered the same. This patch calls the `os.path.normcase` function, which changes all paths to lower-case on Windows and is a noop on Linux. I experienced this problem myself and with this patch this fixes the issue for me.
1 similar comment
|
Missing line because my test suite does not test windows. Ill file an issue to add windows to travis |
|
Thanks for the PR! Glad to see windows getting some love |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a subtle problem on Windows, which is case-preserving but case-insensitive.
Depending from where the user executed the coverage command to produce the XML file, the
<sources>tag might contain a different case in the drive letter:w:\foo\barvsW:\foo\bar(note the case of the first letter). On Windows both paths should be considered the same.This patch calls the
os.path.normcasefunction, which changes all paths to lower-case on Windows and is a noop on Linux.I experienced this problem myself and with this patch this fixes the issue for me.