Fixed an issue where jacoco coverage information was not matching source information on windows

[kingchad1989]

Fixed issue reported in #104

[coveralls]

Coverage increased (+0.003%) to 99.139% when pulling 28933e0 on kingchad1989:issue-99 into 1fafebc on Bachmann1234:master.

[coveralls]

Coverage increased (+0.003%) to 99.139% when pulling 28933e0 on kingchad1989:issue-99 into 1fafebc on Bachmann1234:master.

[coveralls]

Coverage remained the same at 99.136% when pulling 28933e0 on kingchad1989:issue-99 into 1fafebc on Bachmann1234:master.

[Bachmann1234]

Heh... I usually notify people. Sorry about that. I just released it like a half hour ago or so.

On Mon, Jun 3, 2019 at 10:20 PM kingchad1989 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In diff_cover/violationsreporters/violations_reporter.py <#111 (comment)> : > @@ -129,7 +129,7 @@ def _get_src_path_line_nodes_clover(self, xml_document, src_path): def _measured_source_path_matches(self, package_name, file_name, src_path): # find src_path in any of the source roots for root in self._src_roots: - if GitPathTool.relative_path(os.path.join(root, package_name, file_name)) == src_path: + if os.path.normcase(GitPathTool.relative_path(os.path.join(root, package_name, file_name))) == os.path.normcase(src_path): Happy to help! Any idea when a release will be available with the fix? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#111>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALTLRILYQ5RMVOAUOMP64TPYXGPTANCNFSM4HSI7XEQ> .

-- -Matt Bachmann