Benp/jshint violations #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ill take a look today or tomorrow! |
|
yo @Bachmann1234 looks like I have broken tests :( I'll address those and let you know when it's GTG for you. Sorry about that... |
3 similar comments
1 similar comment
| class JsHintQualityReporterTest(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
|
|
There was a problem hiding this comment.
delete this blank line. Sorry to flake8 you. Don't care about the long lines though (im looking at the diff-quality report :-P)
|
A couple trivial comments. Looks pretty good to me. Can you squash this down? |
benpatterson
force-pushed
the
benp/jshint-violations
branch
2 times, most recently
from
4eb748f
to
68dc4a4
Compare
1 similar comment
Because jshint is (at the moment) not available through a python library/port, confirming that it is available at runtime needs to happen through a subprocess call, rather than a python import. The base class for the violations reporter now has a fallback option of checking for a given reporter through the CLI; however, the implementing class must provide the command that verifies it's installed. That command must exit 0 if the tool is successfully installed. (For jshint, it is `jshint --version`).
benpatterson
force-pushed
the
benp/jshint-violations
branch
from
68dc4a4
to
f161ffa
Compare
|
@Bachmann1234 Added tests, fixed up flake8, and squashed. Happy to iterate again if you've got additional comments. |
|
Cool ill give this a last once over soon! |
|
Lets do this! Thanks for the PR |
|
https://pypi.python.org/pypi/diff_cover ITS OUT! :-) Thanks again |
|
Awesome!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Bachmann1234 mind taking a look?