Pass --no-color to git diff #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff-cover is not working when git configuration color.ui=always is set.
|
Thanks for the fix. Can you update the corresponding tests and add yourself to the authors file? |
|
Done, thanks! |
|
fantastic! Ill merge and release tonight |
|
Great, thanks! |
Bachmann1234
added a commit
that referenced
this pull request
Nov 24, 2015
Pass --no-color to git diff
|
Thanks for fast release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff-cover is not working when git configuration color.ui=always is set.