Move logging configuration to main(). #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the current code is that it fails w/ the following message when
diff-cover
tool is executed after fresh installation:The reason is that the default logger is configured at the module level, when the
diff_cover.tool
is executed as a standalone script:However the script that is present in
bin
after installation usingpip install diff-cover==0.9.6
imports themain
function, which doesn't contain thebasicConfig
call.Also, in #42, it was suggested that
basicConfig
call is moved to themain
.Alternative would be to perform logger configuration in
bin/diff-cover
, if there's a reason not to place it inmain
?