Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 47. and 48 Actually use all the files.... and dont run over deleted ones #49

Merged
merged 4 commits into from
Aug 13, 2016

Conversation

Bachmann1234
Copy link
Owner

This one was embarrassing. I suspect I broke it during the grand refactoring a while back.

Here is the original issue:
#47

I am going to look at issue48 before merging this. Maybe combine them as one release.

… its *only* used when passing in reports. Otherwise just add to the report dict direcrtly
@coveralls
Copy link

coveralls commented Aug 13, 2016

Coverage Status

Coverage decreased (-0.2%) to 98.797% when pulling decbf17 on issue-47 into 0c593e8 on master.

@coveralls
Copy link

coveralls commented Aug 13, 2016

Coverage Status

Coverage increased (+0.0009%) to 99.038% when pulling 85a7349 on issue-47 into 0c593e8 on master.

@Bachmann1234 Bachmann1234 changed the title Fix issue 47. Actually use all the files.... Fix issue 47. and 48 Actually use all the files.... and dont run over deleted ones Aug 13, 2016
@coveralls
Copy link

coveralls commented Aug 13, 2016

Coverage Status

Coverage increased (+0.01%) to 99.049% when pulling 552bfe4 on issue-47 into 0c593e8 on master.

@Bachmann1234 Bachmann1234 merged commit da0c5e6 into master Aug 13, 2016
@Bachmann1234 Bachmann1234 deleted the issue-47 branch August 13, 2016 03:40
@fperrin
Copy link

fperrin commented Aug 14, 2016

Hi Matt,
Same comment, new version of diff-cover does fix the issue I was seeing in our repo, so looks good to me. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants