New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'd like to be able to use next-error and previous-error in Emacs with diff-cover's output #51
Conversation
Looks good, tests broke due to the change in output but should be easy to fix. Thanks for the PR! |
@Bachmann1234 thanks! I was mainly filing this as a feature-request; any pointers on where I should look to fix the tests? |
Sure! So the diff-cover/diff-quality test suite is... integration test heavy. A lot of the tests depend on the output of specific commands/reports. So your pr modified the console report template. Looking at the failures updating these files would fix things
It may not be obvious what the src_path should be in the errors. But I guess you can just see what is outputting and base your changes on that. Make sense? Or you can look at the corresponding diff fixture the test loads up. |
As a separate question. Is there any other work I would need to support this emacs feature? Or does this PR cover it. I am fairly ignorant of Emacs but if you know the things that can be done I can make a note to do them when I get around to it. Though full disclosure, its looking like a super busy few months for me so for the most part im mostly in "triage" mode. |
Nope, emacs has a pretty standard regex that will work if you run stuff from |
Was this just closed because it has been stale for a while or is there a different fix available? |
Mostly cuse its stale.... looking back over the changes there actually may not be a need to close. I was closing old PRs because the code had changed a fair amount... But this change is fairly simple... Let me reopen. I cant promise anything but perhaps I can find sometime in January to give this some love. |
Thanks a ton! |
This is now stacked on top of #76 so that should probably be merged first, but I believe the tests should pass now. |
Nice! Ill look this over either later tonight or tomorrow! |
Thanks so much for bearing with me over such a long period of time :) |
This is similar to
-f parseable
from pylint - which, oddly, diff-cover appears to require although it can't output :)