Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pydocstyle support #64

Merged
merged 3 commits into from
Jul 21, 2017
Merged

add pydocstyle support #64

merged 3 commits into from
Jul 21, 2017

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Jul 17, 2017

Closes #52

@coveralls
Copy link

coveralls commented Jul 17, 2017

Coverage Status

Coverage decreased (-0.05%) to 99.024% when pulling 202d793 on mr-c:pydocstyle into b154751 on Bachmann1234:master.

@Bachmann1234
Copy link
Owner

Awesome! Thanks for the PR.

Only issue is this needs some tests. There should be a bunch of examples in the code

@coveralls
Copy link

coveralls commented Jul 18, 2017

Coverage Status

Coverage decreased (-0.03%) to 99.035% when pulling 9acc2ab on mr-c:pydocstyle into b154751 on Bachmann1234:master.

@Bachmann1234
Copy link
Owner

Looks like python 2.6 is not working quite right. Not 100% clear why. Ill see if I can find some time to look into this

@lyndsysimon
Copy link

It looks like pydocstyle doesn't support 2.6. The failing test for 2.6 is happening because pydocstyle --version returns the following traceback under 2.6:

Traceback (most recent call last):
  File "/Users/lyndsy.simon/src/pypi/diff-cover/.tox/py26/bin/pydocstyle", line 7, in <module>
    from pydocstyle.cli import main
  File "/Users/lyndsy.simon/src/pypi/diff-cover/.tox/py26/lib/python2.6/site-packages/pydocstyle/__init__.py", line 1, in <module>
    from .checker import check
  File "/Users/lyndsy.simon/src/pypi/diff-cover/.tox/py26/lib/python2.6/site-packages/pydocstyle/checker.py", line 11, in <module>
    from . import violations
  File "/Users/lyndsy.simon/src/pypi/diff-cover/.tox/py26/lib/python2.6/site-packages/pydocstyle/violations.py", line 242
    'pep257': all_errors - {'D203', 'D212', 'D213', 'D214', 'D215', 'D404',
                                  ^
SyntaxError: invalid syntax

@Bachmann1234
Copy link
Owner

Ah. That makes sense. Good on them.

But for our purposes I think all that's needed is a better error message. "Pydocstyle does not support python 2.6"

If the build is still complaining about coverage after that I'll work around it

@coveralls
Copy link

coveralls commented Jul 21, 2017

Coverage Status

Coverage increased (+0.01%) to 99.081% when pulling fee69a9 on mr-c:pydocstyle into b154751 on Bachmann1234:master.

@mr-c
Copy link
Contributor Author

mr-c commented Jul 21, 2017

I think this is ready for merging, thanks!

I made an issue to provide a better user experience with pydocstyle and Python 2.6: PyCQA/pydocstyle#271

@Bachmann1234
Copy link
Owner

Yep! I'll merge and do a release sometime this weekend or early next week (Monday at the latest )

@Bachmann1234
Copy link
Owner

Thanks!

@Bachmann1234 Bachmann1234 merged commit 68376ac into Bachmann1234:master Jul 21, 2017
@mr-c mr-c deleted the pydocstyle branch July 22, 2017 05:05
@Bachmann1234
Copy link
Owner

Released! Thanks https://pypi.python.org/pypi/diff_cover/0.9.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants