Add support for popular java tools #68
Conversation
1 similar comment
|
Neat! Ill review this in detail this weekend. |
| ['java', '-jar', 'checkstyle-8.5-all.jar', '-c', | ||
| '/google_checks.xml'] | ||
| ) | ||
| self.command_to_check_install = ['java', '-cp', 'checkstyle-8.5-all.jar', 'com.puppycrawl.tools.checkstyle.Main', '-version'] |
There was a problem hiding this comment.
Is there any way to have this less dependent on this specific version of checkstyle?
|
I like it, Im willing to loop past the .05% drop in coverage. Can you update the readme to inform people about this. Make sure to include the versions of the supported tools. |
|
Merging! I'll do a release sometime this week. Thanks! |
|
Thank you, this is a great tool :) |
|
thanks! Released https://pypi.python.org/pypi/diff_cover/1.0.1 |
| """ | ||
| files = [file_tree | ||
| for file_tree in xml_document.findall(".//file") | ||
| if file_tree.get('path') == src_path |
There was a problem hiding this comment.
@Bachmann1234 @peterg79 Before the equality check, we probably need to sanitize the path to unix path. Something like this [1]. Due to this clover reports generated under windows are not working with "GIT BASH"
There was a problem hiding this comment.
@rishi05091989 Do you have some sample data I can use to test? I have no access to a windows computer these days.
There was a problem hiding this comment.
@peterg79 Thanks for your reply. The file tag in clover report looks like this,
<file path="C:\Users\guides_rishi\rishi_guides\guides\bundles\ds-guide-core\src\main\java\com\guide\themes\model\BreakpointInfo.java" name="BreakpointInfo.java">
Also, is it possible to use the clover and cobertura XML together ? As of today, only one coverage report can be used at a time(mixed is not supported).
There was a problem hiding this comment.
is it possible to use the clover and cobertura XML together
yes, with the latest release: #87
need to sanitize the path to unix path
I'll take a look at it soon
Implement support for clover code coverage and checkstyle