Support Jacoco XML report #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterg79
changed the title
added 2 commits
October 25, 2018 13:34
peterg79
changed the title
|
Neat! Thanks for this. I'll try to look at it this weekend |
diff_cover/tool.py
Outdated
| elif jacoco_xml_roots: | ||
| coverage = JacocoXmlCoverageReporter(jacoco_xml_roots, src_roots) | ||
| else: | ||
| assert False |
There was a problem hiding this comment.
Whats happening here? Should we be raising something specific?
| for root in self._src_roots: | ||
| _files = [_file | ||
| for _file in pkg.findall('sourcefile') | ||
| if GitPathTool.relative_path(os.path.join(root, pkg.get('name'), _file.get('name'))) |
There was a problem hiding this comment.
Nitpick, but perhaps making this a named method can make it clearer what this is doing.
maybe something like _get_measured_source_path(src_root, package_name, file_name)
| # First case, need to define violations initially | ||
| if violations is None: | ||
| violations = set( | ||
| Violation(int(line.get('nr')), None) |
There was a problem hiding this comment.
any idea what 'nr' stands for? Can it be a constant?
|
This is looking pretty good. Thank you! I left a couple small comments. |
|
Thanks! Comments addressed. Let me know if you need more changes. Please see #87 - I don't think this should be a separate release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for jacoco code coverage (xml output, not the exec format)
XML Report DTD can be found here: https://www.jacoco.org/jacoco/trunk/doc/
Addresses issues #80 and #82