Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce noprefix=no for git diff config #94

Merged
merged 1 commit into from Mar 16, 2019

Conversation

beaugunderson
Copy link
Contributor

@beaugunderson beaugunderson commented Mar 14, 2019

Fixes #93.

I tried to make the execute args break semantically, let me know if you prefer to just let them flow to fill the available space instead. :)

Note that I tried to run the tests but got a lot of unrelated failures when running tox; specifically nose failed to run.

This was the error:

py37 runtests: commands[0] | coverage run -m nose
........usage: python -m nose [-h] --violations TOOL [--html-report FILENAME]
                      [--external-css-file FILENAME] [--compare-branch BRANCH]
                      [--options [OPTIONS]] [--fail-under SCORE]
                      [--ignore-staged] [--ignore-unstaged]
                      [--exclude EXCLUDE [EXCLUDE ...]]
                      [input_reports [input_reports ...]]
python -m nose: error: the following arguments are required: --violations
usage: python -m nose [-h] --violations TOOL [--html-report FILENAME]
                      [--external-css-file FILENAME] [--compare-branch BRANCH]
                      [--options [OPTIONS]] [--fail-under SCORE]
                      [--ignore-staged] [--ignore-unstaged]
                      [--exclude EXCLUDE [EXCLUDE ...]]
                      [input_reports [input_reports ...]]
python -m nose: error: the following arguments are required: --violations

@beaugunderson
Copy link
Contributor Author

Hmm I see Travis failed with the same error, my guess is due to not pinning a specific version of nose in the requirements, and the required arguments changed in the newer version?

@Bachmann1234
Copy link
Owner

Ill try and take a look over the weekend. Let me run a build on master and see whats going on there

@Bachmann1234
Copy link
Owner

@beaugunderson
Copy link
Contributor Author

@Bachmann1234 very interesting; i did try running tests for master locally and they failed in the same way...

@beaugunderson
Copy link
Contributor Author

i see the issue! will fix shortly

@beaugunderson
Copy link
Contributor Author

ok, these should pass now 👍

worth noting that the error in the description above appears even in the passing builds, so it was a red herring :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 99.206% when pulling 16715c5 on beaugunderson:master into 05c7a00 on Bachmann1234:master.

@Bachmann1234
Copy link
Owner

Thanks for the PR, ill put out a release today!

@Bachmann1234 Bachmann1234 merged commit a7edd91 into Bachmann1234:master Mar 16, 2019
@Bachmann1234
Copy link
Owner

@beaugunderson
Copy link
Contributor Author

beaugunderson commented Mar 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants