Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme copyediting #2

Open
reedy opened this issue Sep 14, 2018 · 0 comments
Open

Readme copyediting #2

reedy opened this issue Sep 14, 2018 · 0 comments

Comments

@reedy
Copy link

reedy commented Sep 14, 2018

Hello! there seems to be a couple of missing words in your Readme and it sounds a bit odd :)

The polyfills slow down your application by adding function_exists, extension_loaded or php version checks that
are when your autoloader is loaded. By removing the polyfills the start up time is (slightly) reduced.

I think that should be "checks that are run when" not "checks that are when"

If you do add this or one of its child packages, consider adding extension as a requirement to your composer.json.

Should this be (adding a this), and possibly extension replaced with package?

If you do add this or one of its child packages, consider adding this extension as a requirement to your composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant