feature: specify other binary basenames #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelfoppolo
requested changes
Aug 21, 2019
Syncing fork
…un-sonar-swift.sh for code coverage reports with slather
davidy4ng
force-pushed
the
feat/slather-multiple-binaries
branch
from
6efa092
to
2d9d335
Compare
…and replced by sonar.coverage.binaryNames
gaelfoppolo
approved these changes
Aug 24, 2019
gaelfoppolo
added a commit
that referenced
this pull request
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the sonar.coverage.otherBinaryNames in the sonar-project.properties template and the run-sonar-swift.sh script.
For some projects, we may have code developed as side projects or frameworks in a workspace. This new field will add the ability to generate code coverage reports by including those frameworks.
It will append in the slather command as many "--binary-basename BinaryName" as provided in the otherBinaryNames field.