domainname/hostname validation with _

[MikeAT]

Hi,

When parsing records like this

$ORIGIN _domainkey.mydomain.at.
XXXXXXXXXXl 3600 CNAME XXXXXXXX.dkim.amazonses.com.

I got this exceptions

Zone "_domainkey.mydomain.at." is not a fully qualified domain name.

I think this is related to #65 (domainanme vs. hostname).

Best,
Michael

[samuelwilliams]

My understanding is that the zone had to be a FQDN - this is the first-time I have encountered an underscore in a zone name.

[MikeAT]

The zonefile is like this:

$ORIGIN mydomain.at.
www
....
$ORIGIN _domainkey.mydomain.at.
XXXXXXXXXXl 3600 CNAME XXXXXXXX.dkim.amazonses.com.

Bind is processing this without any errors/warnings.

[samuelwilliams]

Sorry for the long delay - this is the first time I have seen multiple $ORIGIN control entries defined in a zone. I had to look up the docs to ensure it was legit.

I will need to make a BC breaking change to the Parser in order to address the issue see https://github.com/Badcow/DNS/blob/master/lib/Parser/Parser.php#L223

Thanks for the issue!

[samuelwilliams]

@MikeAT - once again, thank you for bringing this issue to light. I have pushed a change to the master branch that should resolve your issue here. Could you please confirm that it has?

[MikeAT]

Looks good now. Thank you very much for the fix.