Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Commit

Permalink
Dependency updates (#4)
Browse files Browse the repository at this point in the history
* chore: Add eslint-plugin-ember as a peer dependency

Without the user having this installed, it is possible to trigger `Definition for rule 'rule-name' was not found`

* chore: Don't extend `@bagaar/eslint-config`

BREAKING CHANGE: Since `@bagaar/eslint-config-ember` does not override any rules of `@bagaar/eslint-config`, extending has no real benefit besides not having to include `@bagaar/eslint-config` inside a project's extends.
Removing the extend also has the benefit that we can switch out the ESLint specific config without having to change this library.

* chore: Update the README

Remove references to `@bagaar/eslint-config-ember` and add a note about the eslint-plugin-ember dependency.
  • Loading branch information
Windvis authored and Sam Van Campenhout committed Feb 4, 2019
1 parent b31cd84 commit 0ceb6c6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ EsLint config for Bagaar Ember addons and projects.

## Installation

⚠️ **`@bagaar/eslint-config-ember` depends on `@bagaar/eslint-config`. Make sure to install `@bagaar/eslint-config` as well.**
⚠️ **`@bagaar/eslint-config-ember` overrides rules provided by the [`ember-plugin-eslint`](https://github.com/ember-cli/eslint-plugin-ember) plugin. Make sure it is installed and configured properly.**

### npm

```shell
npm install @bagaar/eslint-config @bagaar/eslint-config-ember --save-dev
npm install @bagaar/eslint-config-ember --save-dev
```

### yarn

```shell
yarn add @bagaar/eslint-config @bagaar/eslint-config-ember --dev
yarn add @bagaar/eslint-config-ember --dev
```

## Usage
Expand Down
3 changes: 0 additions & 3 deletions lib/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
module.exports = {
extends: [
'@bagaar/eslint-config',
],
rules: {
'ember/alias-model-in-controller': 'error',
'ember/avoid-leaking-state-in-components': 'error',
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,8 @@
"eslint": "^5.12.1",
"eslint-plugin-ember": "^6.2.0",
"standard-version": "^4.4.0"
},
"peerDependencies": {
"eslint-plugin-ember": "^6.2.0"
}
}
1 change: 1 addition & 0 deletions tests/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = {
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'@bagaar/eslint-config',
'../lib/index.js',
],
env: {
Expand Down

0 comments on commit 0ceb6c6

Please sign in to comment.