This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Dependency updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2019 15:29
Without the user having this installed, it is possible to trigger 'Definition for rule 'rule-name' was not found'
BREAKING CHANGE: Since `@bagaar/eslint-config-ember` does not override any rules of `@bagaar/eslint-config`, extending has no real benefit besides not having to include `@bagaar/eslint-config` inside a project`s extends. Removing the extend also has the benefit that we can switch out the ESLint specific config without having to change this library.
Remove references to `@bagaar/eslint-config-ember` and add a note about the eslint-plugin-ember dependency.
Windvis
force-pushed
the
chore/dependency-updates
branch
from
5e06f28
to
9153937
Compare
Windvis
added a commit
that referenced
this pull request
Feb 4, 2019
* chore: Add eslint-plugin-ember as a peer dependency Without the user having this installed, it is possible to trigger `Definition for rule 'rule-name' was not found` * chore: Don't extend `@bagaar/eslint-config` BREAKING CHANGE: Since `@bagaar/eslint-config-ember` does not override any rules of `@bagaar/eslint-config`, extending has no real benefit besides not having to include `@bagaar/eslint-config` inside a project's extends. Removing the extend also has the benefit that we can switch out the ESLint specific config without having to change this library. * chore: Update the README Remove references to `@bagaar/eslint-config-ember` and add a note about the eslint-plugin-ember dependency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1 and #2.