Fixes to Request.params

Bailador · Oct 27, 2012 · a1159fa · a1159fa
1 parent bdf4db6
commit a1159fa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/Bailador/Request.pm b/lib/Bailador/Request.pm
@@ -5,8 +5,8 @@ class Bailador::Request {
 
     method params {
         my %ret;
-        for $.env<psgi.input>.split('&') -> $p {
+        for $.env<psgi.input>.decode.split('&') -> $p {
-            my $pair = $p.split('=');
+            my $pair = $p.split('=', 2);
             %ret{$pair[0]} = uri_unescape $pair[1];
         }
         return %ret;

diff --git a/t/05-post-content.t b/t/05-post-content.t
@@ -0,0 +1,16 @@
+use Test;
+use Bailador;
+use Bailador::Test;
+
+plan 3;
+
+post '/foo' => sub { request.env<psgi.input>.decode };
+
+my $data = 'hello=world&a=1;b=2';
+my $req  = Bailador::Request.new_for_request('POST', '/foo');
+   $req.env<psgi.input> = $postdata.encode('utf-8');
+my $resp = Bailador::dispatch_request($req);
+
+lives_ok { eager $req.params<hello> }, 'Request data parses without dying';
+is ~$resp.content, $data,   'POST data string roundtrips correctly';
+is $req.params<a>, '1;b=2', 'application/x-www-form-urlencoded POST data should only split on &';