Reproduce issue 1: Retrieving network printer status fails after subsequent attempts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add buttons to UI to get status, releasing port once or twice
physphil
commented
Nov 30, 2021
Comment on lines
+20
to
+29
| private val _printerStatus = MutableSharedFlow<String>() | ||
| val printerStatus = _printerStatus.asSharedFlow() | ||
|
|
||
| init { | ||
| backgroundScope.launch { | ||
| starIoExtManagerWrapper.printerStatus.collect { status -> | ||
| _printerStatus.emit(status) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@Baileypollard I modified some code here in order to emit printer statuses from either the StarIoExtManager or by calling the starSdk.getWifiPrinterStatus() method. Can you take a quick look and verify this still works as expected in your case?
physphil
commented
Nov 30, 2021
Comment on lines
+24
to
+25
| Text("MAC address: \(portInfo.macAddress)") | ||
| Text("Port name: \(portInfo.portName)") |
There was a problem hiding this comment.
I added some titles to this text for clarity.
physphil
changed the title
Baileypollard
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to reproduce the issue where retrieving network printer statuses fails after multiple attempts. Getting a printer status works correctly the first time, but fails the second time with the following error:
During development it was discovered that calling
SMPort.releasePort(port)twice will successfully release the port and the status can be retrieved, whereas calling it only once will not.STR:
Scan Networkfor the app to discover the Wi-Fi printer. Select the printer from the list.Get status, release port TWICE. Verify the printer status changes toOnline.Get status, release port TWICEa few more times, verifying the status is alwaysOnline.Get status, release port ONCE, verify the status isOnline.Get status, release port ONCEagain, and verify the status changes toOfflineafter a few seconds, with the following error message logged. Any subsequent attempt to get the printer status will result in this failure.