Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to RandomPicker to remove items when picked #3

Closed
Balastrong opened this issue Aug 10, 2022 · 0 comments · Fixed by #13
Closed

Add config to RandomPicker to remove items when picked #3

Balastrong opened this issue Aug 10, 2022 · 0 comments · Fixed by #13
Assignees
@Balastrong
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Balastrong
Copy link
Owner

A new boolean option can be passed in the constructor.

If enabled, every time an item is picked it is also removed from the items list.

Testing notes: handle when all items have been removed!
@Balastrong Balastrong added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2022
@Balastrong Balastrong mentioned this issue Aug 10, 2022
Open
@Balastrong Balastrong self-assigned this Aug 23, 2022
@Balastrong Balastrong mentioned this issue Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balastrong Balastrong

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove items when picked Balastrong/wrand
1 participant
@Balastrong