Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vendor/bin/rr get --location bin/ into symfony recipe #15

Open
barell opened this issue Aug 19, 2020 · 2 comments
Open

Move vendor/bin/rr get --location bin/ into symfony recipe #15

barell opened this issue Aug 19, 2020 · 2 comments

Comments

@barell
Copy link

barell commented Aug 19, 2020

Hi, thanks for creating this bundle!

I wonder if we could move this step:
vendor/bin/rr get --location bin/

into symfony flex recipe?

Or is there any reason not to do that?

My use case is that I run composer install on build environment and it would be nice if I don't need to do more manual steps.
Otherwise I will need to create some script to check if the rr binary exists, and execute this step if not.

@Baldinof
Copy link
Owner

Hi! Thanks for using this bundle :)

This is actually a great idea as vendor/bin/rr get will download the binary only if it's missing!

I will add to the flex recipe an auto-script, so this will be executed on every composer install and update.

I plan to release 1.3 soon and it will require a flex recipe update, I will apply your suggestion to the recipe PR.

While waiting for that you can manually add "rr get --location %BIN_DIR%": "script" to your auto-scripts section in composer.json

@barell
Copy link
Author

barell commented Aug 19, 2020

Thank you! Just tested it, works great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants