Changes to keep welcome screen UI above keyboard. Pasteboard button. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome! Thanks for contributing, merging it right away 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love this app idea. Thanks for putting this together. I noticed when I first ran it that it wasn't entirely clear how to get the video to start playing because the "Start Video" button was hidden behind the keyboard. I made some changes such that the UI lives above the keyboard and on really small screens (iPhone 4/4S), the keyboard appearing changes the content view of the scroll view so that you can scroll to view the buttons or gesture to close the keyboard.
In addition, I added a button next to "Start Video" called "Paste Clipboard" which just saves the user a couple of taps by pasting the contents of the Pasteboard (Clipboard) straight into the text field. The keyboard also appears immediately when the WelcomeViewController is displayed on screen.