Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate vgm/s98 export #100

Closed
jpcima opened this issue Apr 11, 2019 · 4 comments
Closed

Accelerate vgm/s98 export #100

jpcima opened this issue Apr 11, 2019 · 4 comments

Comments

@jpcima
Copy link
Contributor

jpcima commented Apr 11, 2019

The task is a bit slow, especially on Nuked which is heavy on the CPU.
Since we don't need the sound output, it's great if these exports can bypass the generation when they are exporting a register dump. Then, the export is going to be nearly instantaneous.

@rerrahkr
Copy link
Member

Thanks for request. I fix export process to skip register writing to the emulation core and sample generation at 4bc08cd.

@jpcima
Copy link
Contributor Author

jpcima commented Apr 14, 2019

Nice. Can I rewrite isNeedSampleGeneration as virtual method in ExportContainerInterface ?
The core guidelines recommend against dynamic_cast which has usually slow implementations.
Second, a future export container will be forced to think of implementing the method.

@rerrahkr
Copy link
Member

rerrahkr commented Apr 14, 2019

Thanks, your idea is better than mine 😃

@jpcima
Copy link
Contributor Author

jpcima commented Apr 14, 2019

Great 👍

@jpcima jpcima closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants