Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deselecting "Show row numbers in hex" in the config dialogue does nothing. #176

Closed
Midi-In opened this issue Jan 6, 2020 · 4 comments
Closed

Comments

@Midi-In
Copy link

Midi-In commented Jan 6, 2020

Pretty much what the title says, unticking the checkbox has no effect on the pattern viewport.
Observed on Windows XP SP3 Professional 32 bit

@Midi-In Midi-In changed the title Deselecting "Show row numnbers in hex" in the config dialogue does nothing. Deselecting "Show row numbers in hex" in the config dialogue does nothing. Jan 6, 2020
@Midi-In
Copy link
Author

Midi-In commented Jan 6, 2020

Correction: It only does affect the sequence order window, which i couldn't notice, not having checked that with any module loaded/composed, thus only having a single entry in there.

Still, that's very inconsistent, and maybe you should consider to make it affect all instances of numbering throughout the tracker (I could open a feature request for that, but no point in cluttering more, and I'm actually not sure whether to see it as a bug or an intended behaviour)?

@rerrahkr
Copy link
Member

rerrahkr commented Jan 7, 2020

Thank you for your report.
BambooTracker described about this feature in the configuration dialog:

Display order numbers and the order count on the status bar in hexadecimal.

But I have checked the same settings of 0CC-FamiTracker, that BambooTracker is based on, it changes pattern row number too. So it is necessary to change the behavior of hex/decimal switch.

About consistency, I keep some numbers like tempo in decimal because there are no major problems about it with FamiTracker and Deflemask. I also think differences in behavior from them can cause confusion.

@rerrahkr
Copy link
Member

rerrahkr commented Jan 8, 2020

I changed the behavior to display pattern step number in decimal at b492a76.

@Midi-In
Copy link
Author

Midi-In commented Jan 9, 2020

Thank you!

@Midi-In Midi-In closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants