Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Jump to next/previous pattern using mouse button 4 and 5 (navigational thumb buttons) #179

Closed
Midi-In opened this issue Jan 15, 2020 · 5 comments

Comments

@Midi-In
Copy link

Midi-In commented Jan 15, 2020

Pretty much what the title says, jumping back and forth through the sequence order using the navigational mouse buttons woild come in very handy (the same way OpenMPT does that)

@rerrahkr
Copy link
Member

rerrahkr commented Jan 15, 2020

Thanks for your request.
I have no mouse with XBUTTON (like forward, back button) now, but guessing from the OpenMPT source, XBUTTON1 (back button) is assigned as jumping to the previous order, and XBUTTON2 (forward button) is set as jumping to the next order, is this right?
I'd like to know where is the pattern cursor after jumping (the same number step, head of pattern or other place...) Considering the operation of changing the order list, it seems that the cursor keeps the step position.

@rerrahkr
Copy link
Member

I added this feature at 4e34ed8.

@Midi-In
Copy link
Author

Midi-In commented Jan 17, 2020

Sorry for late reply, i don't check issues that often but to elaborate on this: OpenMPT's behaviour depends on whether the track is being played or not - during playback it will always jump to the beginning of the target pattern, whereas while the song is stopped it will retain the current vertical position, which seems to be the most sane choice for me. Horizonal position (channel) is always retained.

@rerrahkr
Copy link
Member

rerrahkr commented Jan 18, 2020

Thanks for reply! I also changed the tracker to keep vertical position in changing order at f8e7a51.
I will test the button behavior with 5 button mouse at a later date.

EDIT: Since the cursor must always be displayed on the screen due to the consistency of the implementation, the screen transition is partly different from OpenMPT.

@Midi-In
Copy link
Author

Midi-In commented Jan 18, 2020

Thanks a lot for taking this into consideration!

@Midi-In Midi-In closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants