Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPC bank samples imported with incorrect offsets #185

Closed
OPNA2608 opened this issue Feb 27, 2020 · 2 comments
Closed

PPC bank samples imported with incorrect offsets #185

OPNA2608 opened this issue Feb 27, 2020 · 2 comments

Comments

@OPNA2608
Copy link
Member

Tried the new PPC importer with afew banks. Groundseed's PPC bank imported and sounded fine as far as i could tell, however all of Virgin Angel's samples "start too late", i.e. sample 1 starts in the middle of the actual sample and includes the start of the following sample.

I have attached the PPC bank + a recording of what it's supposed to sound like.
@rerrahkr
Copy link
Member

Thanks for your report. I fixed ADPCM address offset in loading samples at e8deb25.

@OPNA2608
Copy link
Member Author

Seems fixed, thanks! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OPNA2608 @rerrahkr