Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Volume Box Aesthetics #401

Closed
wildmatsu opened this issue Aug 10, 2021 · 5 comments
Closed

Windows - Volume Box Aesthetics #401

wildmatsu opened this issue Aug 10, 2021 · 5 comments
Labels
bug Something isn't working qt: 6.x Affects experimental Qt6 (version 6.x)

Comments

@wildmatsu
Copy link
Contributor

wildmatsu commented Aug 10, 2021

Checklist

  • I am reporting exactly 1 bug with this issue. (Sorry, it is two, albeit related issues.)
  • This bug hasn't already been reported.
  • This bug hasn't already been fixed in the latest development build.

Bug Description

The volume spin box at the top of the UI is too narrow, and cannot accommodate the entirety of the text it contains. I suggest making it wider. If the Volume and Octave spinboxes are made the same width as with the Step Highlight spinboxes to the right, that should be wide enough, and it'll look nice to have them all be the same size.

Also, I suggest that capital letters be used rather than lowercase for hexadecimal digits in the volume spinbox. Capital letters for hexadecimal is more aesthetic, as the letters will all be the same size as the numbers, and more legible, as capital letters tend to be larger, simpler shapes than lowercase.

image

How to reproduce

Simply launch the Windows 10 release of BambooTracker. I do not know if the issue affects other releases.

System Information

  • Operating System: Windows 10
  • BambooTracker Version: 0.50
  • Build Type: Official
@wildmatsu wildmatsu added the bug Something isn't working label Aug 10, 2021
@OPNA2608 OPNA2608 added the qt: 6.x Affects experimental Qt6 (version 6.x) label Aug 10, 2021
@OPNA2608
Copy link
Member

Qt6 builds (like the Win10 x64 one) are barely tested and experience known UI differences/problems compared to Qt5 ones (Win7 x86, WinXP x86). This seems like one of those Qt6-specific differences (unless you can replicate this with any of the other Windows builds) so I've marked it as such for bug tracking & reproducing reasons.

@rerrahkr
Copy link
Member

In b91e658, I fixed the value to be displayed in uppercase. I also removed the maximum width settings for the spinbox.

@wildmatsu
Copy link
Contributor Author

I can confirm the volume spinbox appears to display in uppercase. Thanks! I'll confirm the other change as soon as I can successfully build the latest dev version on my own machine.

@wildmatsu
Copy link
Contributor Author

wildmatsu commented Aug 11, 2021

The Windows 10 Build now looks like this.

image

It is significantly improved, but for a few volume values such as 7A and 7C, a few pixels of the right edge of the second digit are cut off. Ideally, I'd like this spinbox to be big enough to accommodate any valid value without cutoff, but it's an extremely minor issue, so if you want to call this issue fixed at this point and close the issue, I won't object. It's up to you. Thanks for addressing this issue so promptly.

@rerrahkr
Copy link
Member

I changed the minimum width of spinboxes at b98776a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qt: 6.x Affects experimental Qt6 (version 6.x)
Projects
None yet
Development

No branches or pull requests

3 participants