-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows - Volume Box Aesthetics #401
Comments
Qt6 builds (like the Win10 x64 one) are barely tested and experience known UI differences/problems compared to Qt5 ones (Win7 x86, WinXP x86). This seems like one of those Qt6-specific differences (unless you can replicate this with any of the other Windows builds) so I've marked it as such for bug tracking & reproducing reasons. |
In b91e658, I fixed the value to be displayed in uppercase. I also removed the maximum width settings for the spinbox. |
I can confirm the volume spinbox appears to display in uppercase. Thanks! I'll confirm the other change as soon as I can successfully build the latest dev version on my own machine. |
The Windows 10 Build now looks like this. It is significantly improved, but for a few volume values such as 7A and 7C, a few pixels of the right edge of the second digit are cut off. Ideally, I'd like this spinbox to be big enough to accommodate any valid value without cutoff, but it's an extremely minor issue, so if you want to call this issue fixed at this point and close the issue, I won't object. It's up to you. Thanks for addressing this issue so promptly. |
I changed the minimum width of spinboxes at b98776a. |
Bug Description
The volume spin box at the top of the UI is too narrow, and cannot accommodate the entirety of the text it contains. I suggest making it wider. If the Volume and Octave spinboxes are made the same width as with the Step Highlight spinboxes to the right, that should be wide enough, and it'll look nice to have them all be the same size.
Also, I suggest that capital letters be used rather than lowercase for hexadecimal digits in the volume spinbox. Capital letters for hexadecimal is more aesthetic, as the letters will all be the same size as the numbers, and more legible, as capital letters tend to be larger, simpler shapes than lowercase.
How to reproduce
Simply launch the Windows 10 release of BambooTracker. I do not know if the issue affects other releases.
System Information
The text was updated successfully, but these errors were encountered: