Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] - Note entry layout graphic mislabeled #410

Closed
OPNA2608 opened this issue Aug 27, 2021 · 0 comments · Fixed by #411
Closed

[All] - Note entry layout graphic mislabeled #410

OPNA2608 opened this issue Aug 27, 2021 · 0 comments · Fixed by #411
Labels
bug Something isn't working

Comments

@OPNA2608
Copy link
Member

Checklist

  • I am reporting exactly 1 bug with this issue.
  • This bug hasn't already been reported.
  • This bug hasn't already been fixed in the latest development build.

Bug Description

The keyboard keys in the note entry layout ""graphic"" are broken.

Bildschirmfoto_2021-08-27_13-43-22

As you can see, the 3 next-octave-keys on the right are all shifted up by one half-step (C# should be C etc).

Bug was introduced by 9a260de.

ui->lowASLabel->setText(man.getNoteName(10));
ui->lowBLabel->setText(man.getNoteName(11));
ui->lowHighCLabel->setText(man.getNoteName(0));
ui->lowHighCLabel->setText(man.getNoteName(1));
ui->lowHighCSLabel->setText(man.getNoteName(2));
ui->lowHighDLabel->setText(man.getNoteName(3));

ui->highASLabel->setText(man.getNoteName(10));
ui->highBLabel->setText(man.getNoteName(11));
ui->highHighCLabel->setText(man.getNoteName(0));
ui->highHighCLabel->setText(man.getNoteName(1));
ui->highHighCSLabel->setText(man.getNoteName(2));
ui->highHighDLabel->setText(man.getNoteName(3));

The *HighCLabels are listed twice with increasing naming indices.

How to reproduce

  1. Go to Configuration -> Keys
  2. See screenshot above.

System Information

  • Operating System: NixOS Linux 21.05
  • BambooTracker Version: v0.5.0
  • Build Type: local
@OPNA2608 OPNA2608 added the bug Something isn't working label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant