[Windows,macOS,Linux] - .ico embeds are not displaying properly

[OPNA2608]

Checklist

• I am reporting exactly 1 bug with this issue.
• This bug hasn't already been reported.
• This bug hasn't already been fixed in the latest development build.

---

Bug Description

The BambooTracker icon on the Welcome window has disappeared at some point, not sure when.

How to reproduce

1. Help -> Welcome…
2. See screenshots

Native, self-compiled & make installd:

Win7 dev build, running under Wine:

System Information

• Operating System: Linux
• BambooTracker Version: b4347f3
• Build Type: Locally & Official Windows 7 dev build via Wine

[OPNA2608]

I went as far back as aa4efb0 which introduced the icon to the Welcome window, and it seems like this never worked correctly?

[OPNA2608]

Icon actually displays fine on macOS. On Linux & the Windows builds (at least under Wine) it's broken.

[rerrahkr]

Thank you for your report. I notice the "About" dialog also miss the icon image.

build with Qt Creator (win11):

v0.5.0 release bin (for win10):

I haven't looked at it in detail, but it may be failed to display .ico file.

[OPNA2608]

The icon on the About window works on both Linux & macOS, on local builds.

build with Qt Creator (win11):

Someone checked the b4347f3 dev build and the icon isn't there either. I checked the v0.5.0 & 3f59561 (random build i still had downloaded) artifacts on my macOS machine and both didn't display either icons either. But if I locally build both commits against my system Qt, the icons work.

Seems like something we're doing in the packaging is breaking .ico support. A shot in the dark: maybe removing imageformats from the artifacts?

[OPNA2608]

Yep, leaving imageformats inside the Appveyor Windows artifacts seems to fix ico support under Wine. qico.dll is likely the magic library 😉.

The imageformats directory is ~ 2MB on the Win7 dev build.

Do you want to copy around this library on CI so we only ship imageformats/qico.dll and delete everything else, or should we leave the entirety of imageformats in the artifacts?

[rerrahkr]

Since it is better to keep the package size small, I would like to remove non-essential files if possible. However, I don't mind leaving everything if that seems to be difficult.