[Feature] Channel volume indicator

[freq-mod]

I feel that there are some things that could be added from Famitracker (for example)

• channel volume indicators under FMx/SSGx "track heads"
• simple oscilloscope, kinda like in Famitracker or Deflemask
• BPM info at bottom bar
• list of keyboard shortcuts

Also, it feels sometimes weird that after, for example, simply adding instrument/change tempo, pattern gets "shadowed" and you need to click on it to be able to improv or lay notes... DefleMask, Famitracker or Adlib Tracker don't have this.

[rerrahkr]

Thanks for your request. Channel volume indicator and oscilloscope are related to sample stream, so I have trouble with the implementation. The pattern editor and the order list are shaded when adding and changing instrument because the instrument list is focused. In BambooTracker, you can add and change current instrument by keyboard then it needs to move focus to instrument list.

[freq-mod]

In BambooTracker, you can add and change current instrument by keyboard then it needs to move focus to instrument list.

I see. But it could be a nice feature to have a list of keyboard shortcuts in "help" tab?

[freq-mod]

Also, something weird started to happen - I can't add any new pattern or order, everything under "song" tab is grayed out, keyboard shortcuts related to orders don't work.
sth.zip - module that I worked at, if that hepls

[rerrahkr]

"song" tab is grayed out when the order list is not focused. And "pattern" tab is also grayed out when the pattern editor is not focused. Should I remove the restriction?

[freq-mod]

At me it's grayed out even when it seems to be focused...

[rerrahkr]

it is because of jam mode. The tracker prohibits changing orders and patterns in jam mode.

[freq-mod]

Ah, I see now. Thanks for an explanation!

[rerrahkr]

I added BPM at a2efdc5, and @jpcima added oscilloscope #103 (I will arrange layouts of oscilloscope).

[freq-mod]

I see now. Thanks a lot!
Yet I see a very small, cosmetic problem: when editing SSG instrument, in waveform tab, "SMInvSaw" string doesn't fit correctly:

[jpcima]

I'll add one also: the drawings of FM envelope (red) and FM algorithm diagram (blue) need antialiasing.
These pixelation looks unclean on the line segments, and blue lines appear drawn inconsistently as 1 or 2 px wide.

[jpcima]

Channel volume indicator and oscilloscope are related to sample stream, so I have trouble with the implementation.

@rerrahkr I believe volume indicator can be deduced without a direct look at the samples.
One could query effective envelope values in the chip structure.
I think of providing such a query function in the abstract interface.

[rerrahkr]

I add a plain keyboard shortcuts list at f613ae7.

[jpcima]

@rerrahkr much appreciated, thank you.

Note to self, for translation purposes, and @trebmuh:
It's needed to produce a translation of the html document.

In the qrc document, I expect such a section to do the trick.

    <qresource prefix="/doc" lang="fr">
        <file alias="shortcuts">res/doc/keyboard_shortcuts_fr.html</file>
    </qresource>

[freq-mod]

@rerrahkr thank you, it will be very useful!

[freq-mod]

With recent addition of bank format, I started thinking about instrument editor:
Let's say I have a bank of 30 instruments, and I, for example, want to quickly check if there are no duplicates - every instrument selection opens a new instance of editor window, resulting in ~30 windows, unless you close it after checking one instrument and moving to next. 🙄
In FamiTracker, instrument editor's contents are replaced after simply clicking on another instrument, without opening another window. That would certainly be an improvement.

[rerrahkr]

The reason of multiple windows is to enable to edit multiple instruments simultaneously. For example, when editing an envelope with two FM instruments, it is possible to compare the parameters and create tones.