Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect audio output for FM channel 3 #84

Closed
nyanpasu64 opened this issue Mar 25, 2019 · 3 comments
Closed

Incorrect audio output for FM channel 3 #84

nyanpasu64 opened this issue Mar 25, 2019 · 3 comments

Comments

@nyanpasu64
Copy link
Contributor

nyanpasu64 commented Mar 25, 2019 •
edited

Regression caused by 804b7cd .

This commit seems to change and break the sound output of existing .btm file sd3winter-dev.zip. (Is there some oddity with my instrument 5 that causes this issue?)
@OPNA2608
Copy link
Member

Can confirm.

Top is e887448, bottom is current master 4c8a535.
grafik

@rerrahkr
Copy link
Member

Thanks for reports. I mistook register offset in setting pitch data, so I fixed it at 2eaa2f8.

@nyanpasu64
Copy link
Contributor Author

Seems to be fixed in master. Thanks, I wasn't sure if it was a bug or an issue with my module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nyanpasu64 @OPNA2608 @rerrahkr