Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With no file selected, the Calculate button can still be pressed #18

Closed
jackdevey opened this issue May 12, 2022 · 2 comments
Closed

With no file selected, the Calculate button can still be pressed #18

jackdevey opened this issue May 12, 2022 · 2 comments

Comments

@jackdevey
Copy link
Contributor

Dear Russell Banks,

Unfortunately, when you have lately opened this program & thus have no file chosen, the Calculate button still registers press events.

Convention would be to:

  • Disable the button until all required inputs are given and therefore the hash is ready to be calculated, or
  • Produce a suitable error message explaining the user's blunder, requesting they provide a file

Please find a detailed example below:

untitled

As is distinctly visible, no file has been opened & the button click event has been called, wrongly causing Windows to set forth an alternate loading cursor.

Whilst I am obviously aware of the minute complexity of this bug compared to your assumed over decorated schedule, it is nevertheless, naturally, something I would greatly appreciate seeing patched in an upcoming release.

Thank you for taking the time to read & address this issue, I wish you the best of luck in the future!

Yours Sincerely,

Mr. Jack William Devey

@russellbanks
Copy link
Owner

Thank you for highlighting this to me!

I hadn't considered doing it this way previously. Currently, as you have shown, you can still press the button but nothing will happen. However, it would make more sense in UI design to disable the button rather than make it so that nothing happens if you press it.

@jackdevey
Copy link
Contributor Author

Hindsight is a wonderful thing my friend!

russellbanks added a commit that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants