Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future #3

Closed
Deijin27 opened this issue Sep 28, 2022 · 7 comments
Closed

Future #3

Deijin27 opened this issue Sep 28, 2022 · 7 comments

Comments

@Deijin27
Copy link
Collaborator

Hey, would you be interested in continuing to maintain this. I've forked and got it up to speed with the latest version of wren https://github.com/Deijin27/IronWren

If you would like to continue maintaining it, I can make a PR. Else, thanks for creating this for me to work off of, enjoy your day.

@Banane9
Copy link
Owner

Banane9 commented Sep 29, 2022

Hello, I've scrolled through the diff and it seems most of it is adding what I assume are changes to the wren-api?

One thing to note though, is that the .dll extension for the library name on the dll import attributes was specifically missing to allow it to work on linux as well iirc, where the files have a different extension.
https://github.com/Deijin27/IronWren/blob/9bac9ccfb3077eb20b2708716a3610b49a1d1485/IronWren/WrenVM.cs#L20

@Banane9
Copy link
Owner

Banane9 commented Sep 29, 2022

can also make a pull request and add you as a maintainer here if you want to

@Deijin27
Copy link
Collaborator Author

Do you know how to set up the nuget so it properly includes which native binary it needs to run based on the target platform/platforms of the using apppication. I see this discussion here NuGet/Home#6645

@Deijin27
Copy link
Collaborator Author

Yes, the main API difference was the maps, other than that its just minor stuff.

@Deijin27
Copy link
Collaborator Author

If you are happy with adding me as a collaborator rather than going through PRs thats cool with me.

I can go through making the tests more detailed.

Long term I want to see whether it's possible with wren to do something like NLua where you can include any c# class. But I would not suggest anything until I had a proof of concept.

@Banane9
Copy link
Owner

Banane9 commented Oct 1, 2022

Do you know how to set up the nuget so it properly includes which native binary it needs to run based on the target platform/platforms of the using apppication. I see this discussion here NuGet/Home#6645

I've not used NuGet in ages, would've too look into it 😅

Yes, the main API difference was the maps, other than that its just minor stuff.

Just saw that it also introduced a new object / struct for the handling of resolves.

If you are happy with adding me as a collaborator rather than going through PRs thats cool with me.

I can go through making the tests more detailed.

Long term I want to see whether it's possible with wren to do something like NLua where you can include any c# class. But I would not suggest anything until I had a proof of concept.

Hmmm, not sure what NLua does - how close is the current automapper to it?

You could also contact me on discord or Telegram, same name as here, with #5929 for discord.

@Deijin27
Copy link
Collaborator Author

Deijin27 commented Oct 1, 2022

Closing as "Yes"

@Deijin27 Deijin27 closed this as completed Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants